bison-patches
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser

From: Paul Eggert
Subject: Re: push parser
Date: Sat, 16 Dec 2006 16:55:53 -0800
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) 
"Joel E. Denny" <address@hidden> writes:

> +   m4_ifset([b4_parse_param], [,]) b4_parse_param)[

The patch overall looks fine to me, but one minor thing.  In usages
like this, it's better to put the empty item inside the conditional.
That is:

    m4_ifset([b4_parse_param], [, b4_parse_param]))[

This is the usual style in Bison and it's easier to follow.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]