[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: scan-gram.l globals -> static
|
From: |
Joel E. Denny |
|
Subject: |
Re: FYI: scan-gram.l globals -> static |
|
Date: |
Mon, 14 Aug 2006 18:36:53 -0400 (EDT) |
On Mon, 14 Aug 2006, Paul Eggert wrote:
> "Joel E. Denny" <address@hidden> writes:
>
> > 2006-08-14 Joel E. Denny <address@hidden>
> >
> > + * src/scan-gram.l (braces_level, context_state): Make these globals
> > + static.
>
> Those aren't globals -- they are local variables for the scanner.
> So this change hurts performance and makes the scanner less reentrant.
Ugh, sorry, I missed the %%.
> Is this change really needed?
No, I've just been trying to eliminate globals as I encounter them.
> If not, can you please undo it, and
> review other changes you've checked in recently for similar problems?
I will.
Joel