bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Renaming muscles


From: Akim Demaille
Subject: Re: Renaming muscles
Date: 04 Jul 2002 11:23:17 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)

>>>>> "Tim" == Tim Van Holder <address@hidden> writes:

Hi Tim.

Tim> From the old names, I'm assuming nrules is the number of rules.

You are correct.

Tim> As such, rules_number is not that great a name (in English); it
Tim> should either be number_of_rules, or rule_count (and the latter
Tim> is more typically used).  Similar for the others - use
Tim> <singular>_count instead of <plural>_number.  A bit of
Tim> nitpicking, but rules_number I would find harder to immediately
Tim> grasp than nrules (as the n prefix is typically used for counts).

I must say I had that problem when I renamed them.  My problem is that
I'm a prefix person (i.e., I much prefer rules_sth than sth_rule.
Then I prefered `number' since that closer to the names used in
internal.

Nevertheless, I'm fine with changing these.  But I'd prefer having
other opinions: should I use `states_count' etc?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]