Re: FYI [trunk]: rm-useless-options.patch

[Akim Demaille]

| Index: ChangeLog
| ===================================================================
| RCS file: /cvsroot/bison/bison/ChangeLog,v
| retrieving revision 1.322
| diff -u -r1.322 ChangeLog
| --- ChangeLog 2001/11/28 20:32:53     1.322
| +++ ChangeLog 2001/11/28 21:19:20
| @@ -1,5 +1,23 @@
|  2001-11-28  Marc Autret  <address@hidden>
|  
| +     * src/output.h: And put its extern declaration here.
| +     * src/output.c (error_verbose): Define here.
| +     (prepare): Echo name modification.
| +     * src/getargs.h: Clean its extern declaration.
| +     * src/getargs.c (error_verbose_flag): Remove.
| +     (getargs): Remove case 'e'.
| +     * src/options.c (option_table): 'error-verbose' is now seen as simple
| +     percent option.
| +     Include output.h.
| +
| +     * src/reader.c (read_declarations): Remove case tok_include.
| +     (parse_include_decl): Remove.
| +     * src/lex.h (token_t): Remove tok_include.
| +     * src/options.c (option_table): 'include' is now a simple command line
| +     option.

That's good, as the others, thanks.  But please, make sure the
ChangeLog is readable.  Starting with `And put its extern declaration
here.' sounds weird.  Also `here' is pretty useless above.  Also, you
need to keep the name of what you are referring to.  Something like:

| +     * src/output.c (error_verbose): Define.
| +     * src/output.h (error_verbose): Declare.

Or simply

        * src/output.h, src/output.c (error_verbose): New.