Re: [trunk]: new-error-verbose.patch

[Marc Autret]

Akim Demaille <address@hidden> writes:

> | -#if YYDEBUG || YYERROR_VERBOSE
> | +#if %%error_verbose
> 
> Err, what has happened with the YYDEBUG condition?

Oups!

> |  
> | -#if YYERROR_VERBOSE
> | +#if %%error_verbose
> 
> I'm not sure this is the right move: the resulting code will be less
> readable.  

We can comment!

> In addition, be ready to receive bug reports of people
> saying that in that case, we'd better handle the #if 1 by ourselves:
> keep or remove the corresponding code (which we don't want to implement).

Ok.

> | +   break;
> | +
> | +      case 'e':
> | +   error_verbose_flag = 1;
> 
> Do not multiply the number of options.  I don't think we need that
> option really.  I'm sorry I say `no' so often, but in that case we
> want to keep things simple.
> 
> For instance I was *wrong* to add --locations.  %locations was right.
> Do not follow my own mistakes.
> 

Ok.

> | +  muscle_insert ("error_verbose", "0");
> 
> I would much prefer that we keep `-' and `-' only everywhere.  Is that
> a problem somewhere?
> 

The muscle names are parsed with

while (isalnum (c = getc (fskel)) || c == '_')
      obstack_1grow (&muscle_obstack, c);

but we can change...

-- 
Marc Autret