Re: [trunk]: I-option2.patch

[Marc Autret]

Akim Demaille <address@hidden> writes:

> | +  char buff[32];
> 
> This is not acceptable IMHO.

I agree!

> | +     if ((c < '!') && (c > '~'))
> 
> I don't understand, and I shouldn't have to make efforts to understand.
> 

Yes, that's true.
> 
> Also, are you sure the _reader_ should go for a string instead of
> waiting for a string from the scanner.  I tend to think the approach
> is wrong.  The scanner knows how to swallow strings, you should rely
> on that.

I'm not sure that the scanner can do that the time being.
Moreover, the filenames can be built with all characters between
1 and 127 (ascii). That is a special manipulation.
Though it is, there is a problem with my patch...

> But I might be wrong, of course.

:)

-- 
Marc Autret