FYI: Both: Modernize Test Suite

[Akim Demaille]

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * tests/calc.at, tests/output.at, tests/regression.at,
        * tests/testsuite.at, tests/torture.at: Rely on Autotest 2.52g:
        now the tests are run in private dirs, therefore AC_CLEANUP and
        family can be simplified to 0-ary.
        * tests/atlocal.in: Now that we run `elsewhere' than in tests/,
        use abs. path to find config.h.
        * tests/calc.at (AT_CHECK_CALC): Don't try to check the compiler's
        stderr, there can be way too much random noise.
        Instead pass -Werror to GCC and rely on the exit status.
        Reported by Wolfram Wagner.

Index: NEWS
===================================================================
RCS file: /cvsroot/bison/bison/NEWS,v
retrieving revision 1.21.2.22
diff -u -u -r1.21.2.22 NEWS
--- NEWS 2001/11/12 09:19:46 1.21.2.22
+++ NEWS 2001/11/14 15:16:35
@@ -1,6 +1,12 @@
 Bison News
 ----------

+Changes in version 1.30c:
+
+* Fixed a few warnings.
+
+* Some portability issues.
+
 Changes in version 1.30b:

 * Fixed parser memory leaks.
Index: THANKS
===================================================================
RCS file: /cvsroot/bison/bison/THANKS,v
retrieving revision 1.10.2.10
diff -u -u -r1.10.2.10 THANKS
--- THANKS 2001/11/12 09:15:25 1.10.2.10
+++ THANKS 2001/11/14 15:16:35
@@ -26,6 +26,7 @@
 Robert Anisko           address@hidden
 Shura                   address@hidden
 Tom Lane                address@hidden
+Wolfram Wagner          address@hidden
 Wwp                     address@hidden

 Many people are not named here because we lost track of them.  We
Index: tests/atlocal.in
===================================================================
RCS file: /cvsroot/bison/bison/tests/atlocal.in,v
retrieving revision 1.1.2.2
diff -u -u -r1.1.2.2 atlocal.in
--- tests/atlocal.in 2001/10/18 15:24:53 1.1.2.2
+++ tests/atlocal.in 2001/11/14 15:16:35
@@ -10,4 +10,4 @@
 GCC='@GCC@'

 # We need `config.h'.
-CPPFLAGS="-I $top_builddir @CPPFLAGS@"
+CPPFLAGS="-I $top_buildpath @CPPFLAGS@"
Index: tests/calc.at
===================================================================
RCS file: /cvsroot/bison/bison/tests/calc.at,v
retrieving revision 1.5.2.8
diff -u -u -r1.5.2.8 calc.at
--- tests/calc.at 2001/11/02 15:26:33 1.5.2.8
+++ tests/calc.at 2001/11/14 15:16:36
@@ -338,8 +338,14 @@
 # Maybe some day we will have proper Autoconf macros to disable these
 # warnings, but this place is not the right one for that.
 # So let's keep only GCC warnings, which we know are sane.
-AT_CHECK([$CC $CFLAGS $CPPFLAGS calc.c -o calc], 0, [], [stderr])
-AT_CHECK([if test "$GCC" = yes; then cat stderr; else true; fi])
+# Well, that's only part of the story: some assemblers issue warnings
+# which can be totally useless, and actually polluting.  It seems that
+# the best bet be to completely ignore stderr, but to pass -Werror
+# to GCC.
+if test "$GCC" = yes; then
+  CFLAGS="$CFLAGS -Werror"
+fi
+AT_CHECK([$CC $CFLAGS $CPPFLAGS calc.c -o calc], 0, [], [ignore])

 # Test the priorities.
 _AT_CHECK_CALC([$1],
@@ -377,7 +383,7 @@
                      [2.0:2.1],
                      [unexpected `'+''])

-AT_CLEANUP(calc calc.c calc.h calc.output)
+AT_CLEANUP
 ])# AT_CHECK_CALC


Index: tests/output.at
===================================================================
RCS file: /cvsroot/bison/bison/tests/output.at,v
retrieving revision 1.1.2.5
diff -u -u -r1.1.2.5 output.at
--- tests/output.at 2001/11/04 16:26:59 1.1.2.5
+++ tests/output.at 2001/11/14 15:16:36
@@ -31,7 +31,7 @@

 AT_CHECK([bison $3 $1], 0)
 AT_CHECK([ls $4], [], [ignore])
-AT_CLEANUP($4)
+AT_CLEANUP
 ])

 AT_CHECK_OUTPUT([foo.y], [], [-dv],
Index: tests/regression.at
===================================================================
RCS file: /cvsroot/bison/bison/tests/regression.at,v
retrieving revision 1.1.2.13
diff -u -u -r1.1.2.13 regression.at
--- tests/regression.at 2001/11/12 09:19:48 1.1.2.13
+++ tests/regression.at 2001/11/14 15:16:36
@@ -40,7 +40,7 @@

 AT_CHECK([bison -v duplicate.y -o duplicate.c], 0, ignore, ignore)

-AT_CLEANUP([duplicate.*])
+AT_CLEANUP


 ## ------------------------- ##
@@ -139,7 +139,7 @@
     $default   accept
 ]])

-AT_CLEANUP(input.c input.output)
+AT_CLEANUP


 ## --------------------- ##
@@ -236,7 +236,7 @@
     $default   accept
 ]])

-AT_CLEANUP(input.c input.output)
+AT_CLEANUP



@@ -257,7 +257,7 @@
 [input.y contains 1 shift/reduce conflict.
 expected 0 shift/reduce conflicts
 ])
-AT_CLEANUP(input.c)
+AT_CLEANUP


 ## --------------- ##
@@ -276,7 +276,7 @@
 AT_CHECK([bison input.y -o input.c], 0, [],
 [input.y contains 1 shift/reduce conflict.
 ])
-AT_CLEANUP(input.c)
+AT_CLEANUP


 ## ------------------ ##
@@ -296,7 +296,7 @@
 [input.y contains 1 shift/reduce conflict.
 expected 2 shift/reduce conflicts
 ])
-AT_CLEANUP(input.c)
+AT_CLEANUP


 ## ---------------------- ##
@@ -318,7 +318,7 @@

 AT_CHECK([bison -v input.y -o input.c], 0, ignore, ignore)

-AT_CLEANUP([input.*])
+AT_CLEANUP



@@ -341,7 +341,7 @@

 AT_CHECK([bison --defines union.y])

-AT_CLEANUP([union.*])
+AT_CLEANUP


 ## --------------------------------------- ##
@@ -364,7 +364,7 @@
 AT_CHECK([bison union-comment.y])
 AT_CHECK([fgrep '//*' union-comment.tab.c], [1], [])

-AT_CLEANUP([union-comment.*])
+AT_CLEANUP


 ## ----------------- ##
@@ -416,11 +416,9 @@
 m4_define([AT_TEST_CPP_GUARD_H],
 [AT_SETUP([Invalid CPP guards: $1])

-# possibly create and nuke inner directories.
-m4_bmatch([$1], [[/]],
-[dirname=`AS_DIRNAME([$1])`
+# Possibly create inner directories.
+dirname=`AS_DIRNAME([$1])`
 AS_MKDIR_P([$dirname])
-AT_CLEANUP_FILES([$dirname])])

 AT_DATA([$1.y],
 [%%
@@ -432,7 +430,7 @@
 # CPP should be happy with it.
 AT_CHECK([$CC -E $1.h], 0, [ignore])

-AT_CLEANUP($1.*)
+AT_CLEANUP
 ])

 AT_TEST_CPP_GUARD_H([input/input])
Index: tests/testsuite.at
===================================================================
RCS file: /cvsroot/bison/bison/tests/testsuite.at,v
retrieving revision 1.1.2.4
diff -u -u -r1.1.2.4 testsuite.at
--- tests/testsuite.at 2001/11/12 09:14:50 1.1.2.4
+++ tests/testsuite.at 2001/11/14 15:16:36
@@ -19,7 +19,7 @@
 # 02111-1307, USA.

 # We need a recent Autotest.
-m4_version_prereq([2.52e])
+m4_version_prereq([2.52g])

 AT_INIT

Index: tests/torture.at
===================================================================
RCS file: /cvsroot/bison/bison/tests/torture.at,v
retrieving revision 1.1.2.1
diff -u -u -r1.1.2.1 torture.at
--- tests/torture.at 2001/11/12 09:14:50 1.1.2.1
+++ tests/torture.at 2001/11/14 15:16:36
@@ -73,7 +73,6 @@
 ]])
 AT_CHECK([bison input.y -o input.c])
 AT_CHECK([$CC $CFLAGS $CPPFLAGS input.c -o input], 0, [], [ignore])
-AT_CLEANUP_FILES(input input.c)
 ])