Re: [bison-1_29-branch] files.patch

[marc-alexandre autret]

According to Akim Demaille:
> 
> | Hello,
>  
> | +  src_extension = tr (ext, 'y', 'c');
> | +  src_extension = tr (src_extension, 'Y', 'C');
> | +  if (!header_extension)
> |      {
> |        header_extension = tr (ext, 'y', 'h');
> |        header_extension = tr (header_extension, 'Y', 'H');

Here, we compute the header extension from the grammar file.

> | @@ -280,12 +275,12 @@
> | +  if (!header_extension)
> | +    {
> | +      header_extension = tr (ext, 'c', 'h');
> | +      header_extension = tr (header_extension, 'C', 'H');
> | +    }

If the -o option is used, we compute the header extension
from the filename specified.
In both cases, If --defines=FILE is used, we must not compute
the header extension here...
 
> 
> | +  /* If --defines=FILE is used.  */
> | +  if (spec_defines_file)
> | +    {
> | +      ext_index = get_extension_index (spec_defines_file);
> | +      if (ext_index)
> | +   ext_index = 
> | +     (strspn (spec_defines_file + ext_index + 1, "hH")) ? ext_index : 0;
> | +      if (ext_index)
> | +   header_extension = xstrdup (spec_defines_file + ext_index);
>
> I'm a bit lost here.  What are you doing?  If --define=foo.h is
> specified, I don't see much to be computed.
> 

I need your opinion here. I do that in order to apply the header extension
to the other header files like attrsfiles for example but I am not sure 
if we must do that...
 
> 
> |    if (defines_flag)
> | -    defines_obstack_save (stringappend (base_name, header_extension));
> | +    defines_obstack_save (spec_defines_file ?
> | +                     spec_defines_file : stringappend (base_name, 
> | +                                                       header_extension));
> 
> I'd rather put a default value to spec_defines_file or something like
> that.  Compute it only in one place.
> 

euh. You want me to put 

if (!spec_defines_file)
   spec_defines_file = stringappend (base_name, header_extension));

upper in the function?

whatever we do, it must be done after compute_base_names () call.

> 
> Fine!

Thanks.
 
-- 
Autret Marc (address@hidden)
Eleve Ingenieur en Informatique.