Re: [Bayonne-devel] [PATCH] add $(DESTDIR) prefix to configuration dirs

[David Sugar]

I think DESTDIR originally was used as you have changed, but was removed
because it was conflicting with some aspect of how the RPM build process
handled build prefixes for fake build directories with the %makeinstall
macro.  Basically, the spec files passes a sysconfdir path with the fake
build root path and ALSO has DESTDIR set, so you would get something like

/var/tmp/rpm-build-path/etc/bayonne/etc/bayonne !



Zhang Le wrote:
> This way we can make sure DESTDIR option of make could take effect.
> In fact, without this patch, when emerging bayonne2 in Gentoo could cause
> sandbox violation.
> 
> --- config/Makefile.in.orig     2006-08-18 02:03:32.000000000 +0800
> +++ config/Makefile.in  2006-08-18 02:04:17.000000000 +0800
> @@ -258,10 +258,10 @@
> AUTOMAKE_OPTIONS = no-dependencies dist-shar
> EXTRA_DIST = *.conf bayonne.init* instconfig bayonne.log
> RELEASE = -version-info @LT_VERSION@ -release @LT_RELEASE@
> -ETC = $(sysconfdir)
> -CONF = $(sysconfdir)/bayonne
> -INIT = $(sysconfdir)/init.d
> -LOGD = $(sysconfdir)/logrotate.d
> +ETC = $(DESTDIR)/$(sysconfdir)
> +CONF = $(DESTDIR)/$(sysconfdir)/bayonne
> +INIT = $(DESTDIR)/$(sysconfdir)/init.d
> +LOGD = $(DESTDIR)/$(sysconfdir)/logrotate.d
> all: all-am
> 
> .SUFFIXES:
> 
>