[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #10154] Update to serial code management for custom connection pa

From: David Sainty
Subject: [patch #10154] Update to serial code management for custom connection parameters
Date: Fri, 3 Dec 2021 19:19:57 -0500 (EST)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15

Follow-up Comment #2, patch #10154 (project avrdude):

It also looks a bit abusive to add flags to the setspeed() method.  If there
was a new setcflags() method then it could just be not called for all drives
that don't need to change the cflags, and none of the drivers would need to
change at all (default would apply if setcflags() is not called).

On a tangent - if thinking about overhauls, getting rid of the serdev (and
serial_recv_timeout) globals would be nice.

The library relies on the serdev type matching the `union file descriptor *fd`
that is passed around, but an object oriented approach would just have *fd
knowing what type it was.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]