avrdude-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #9757] Fix ATtiny817 Xplained Mini programmer


From: Joerg Wunsch
Subject: [patch #9757] Fix ATtiny817 Xplained Mini programmer
Date: Sun, 20 Sep 2020 16:03:34 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:69.0) Gecko/20100101 Firefox/69.0

Update of patch #9757 (project avrdude):

                  Status:                    None => Need Info              
             Assigned to:                    None => joerg_wunsch           

    _______________________________________________________

Follow-up Comment #5:

Well, I don't think programmers usually have multiple IDs. However, the
avrdude.conf syntax (see config_gram.y) allows for a string_list in that
place.

I guess we don't really need to care for more than one ID, but we need to take
into account that pgm->id points to the *list* rather than the list's datum.

IMHO, the following patch ought to fix it as well, can you verify?


Index: jtag3.c
===================================================================
--- jtag3.c     (revision 1448)
+++ jtag3.c     (working copy)
@@ -867,7 +867,7 @@
   /* XplainedMini boards do not need this, and early revisions had a
    * firmware bug where they complained about it. */
   if (pgm->flag & PGM_FL_IS_EDBG) {
-    if (strcmp(pgm->id, "xplainedmini_updi") != 0) {
+    if (strcmp(ldata(lfirst(pgm->id)), "xplainedmini_updi") != 0) {
       if (jtag3_edbg_prepare(pgm) < 0) {
         return -1;
       }
@@ -1581,7 +1581,7 @@
   /* XplainedMini boards do not need this, and early revisions had a
    * firmware bug where they complained about it. */
   if (pgm->flag & PGM_FL_IS_EDBG) {
-    if (strcmp(pgm->id, "xplainedmini_updi") != 0) {
+    if (strcmp(ldata(lfirst(pgm->id)), "xplainedmini_updi") != 0) {
       jtag3_edbg_signoff(pgm);
     }
   }


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9757>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]