[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avrdude-dev] [RFA] #if cleanups
From: |
Theodore A. Roth |
Subject: |
Re: [avrdude-dev] [RFA] #if cleanups |
Date: |
Mon, 12 Jul 2004 13:41:44 -0700 (PDT) |
On Mon, 12 Jul 2004, E. Weddington wrote:
> On 8 Jul 2004 at 10:55, Theodore A. Roth wrote:
>
> > The attached patch cleans up the indented #if directives. There was only
> > one set that couldn't be elimiated in a somewhat trivial way.
> >
> > I can't test that the change in ppiwin.c compiles since I don't have
> > windows access. Can someone please verify for me that it compiles before
> > I commit (assuming no objections)?
> >
> > Any objections to this patch?
>
> Tried building with patch. Perhaps I'm doing something wrong. The only thing
> that I did differently is during the bootstrap, I tried using autoconf 2.59
> instead of 2.57, which btw it didn't *seem* to have any problems.
>
> This is the last part of the make output:
> ../avrdude/ser_win32.c: In function `serial_baud_lookup':
> ../avrdude/ser_win32.c:66: warning: implicit declaration of function `fprintf'
> ../avrdude/ser_win32.c:66: error: `stderr' undeclared (first use in this
> function)
> ../avrdude/ser_win32.c:66: error: (Each undeclared identifier is reported
> only once
> ../avrdude/ser_win32.c:66: error: for each function it appears in.)
> ../avrdude/ser_win32.c: In function `serial_open':
> ../avrdude/ser_win32.c:108: error: `stderr' undeclared (first use in this
> function)
It doesn't look like stdio.h is getting pulled in. These are the only
includes for that file:
#include <windows.h>
#include <ctype.h> /* for isprint */
#include "serial.h"
---
Ted Roth
PGP Key ID: 0x18F846E9
Jabber ID: address@hidden
- [avrdude-dev] [RFA] #if cleanups, Theodore A. Roth, 2004/07/08
- Re: [avrdude-dev] [RFA] #if cleanups, Brian Dean, 2004/07/08
- autoconf version (was: Re: [avrdude-dev] [RFA] #if cleanups), E. Weddington, 2004/07/09
- Re: [avrdude-dev] [RFA] #if cleanups, E. Weddington, 2004/07/12
- Re: [avrdude-dev] [RFA] #if cleanups,
Theodore A. Roth <=
- Re: [avrdude-dev] [RFA] #if cleanups, E. Weddington, 2004/07/12
- Re: [avrdude-dev] [RFA] #if cleanups, Theodore A. Roth, 2004/07/12
- Re: [avrdude-dev] [RFA] #if cleanups, E. Weddington, 2004/07/12
- RE: [avrdude-dev] [RFA] #if cleanups, Alex Shepherd, 2004/07/15
- RE: [avrdude-dev] [RFA] #if cleanups, E. Weddington, 2004/07/15
- RE: [avrdude-dev] [RFA] #if cleanups, Alex Shepherd, 2004/07/16
- RE: [avrdude-dev] [RFA] #if cleanups, E. Weddington, 2004/07/16