[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] [patch #9187] [AVR_TINY]: Support 16-bit xtoa functon
|
From: |
George Spelvin |
|
Subject: |
Re: [avr-libc-dev] [patch #9187] [AVR_TINY]: Support 16-bit xtoa functons and more string functions. |
|
Date: |
10 Dec 2016 00:17:53 -0500 |
Generally looks good.
There are a couple of places (strlcat.S, strncat.S) where you don't
look at the flags after decremeninting a pointer, and could use a single
"ld __tmp_reg__,-X" instruction rather than the two-instruction X_sbiw
emulation.
(In strrchr.S and strstr.S, it's decrementing r25:r24, so that can't work.)