[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[avr-libc-dev] [bug #32945] Wrong PF implementation in pmstring

From: Pitchumani
Subject: [avr-libc-dev] [bug #32945] Wrong PF implementation in pmstring
Date: Wed, 09 Oct 2013 13:08:19 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.69 Safari/537.36

Follow-up Comment #5, bug #32945 (project avr-libc):

RAMPZ address is hard-coded already (revision 2279) in case of building
avr-libc. This resolves AVR_RAMPZ_ADDR definition error.

I have attached patch (restore-rampz.patch) to restore RAMPZ value for all
xxx_PF() functions.

2013-10-09  Pitchumani Sivanupandi <address@hidden>

        Fix for bug #32945.
        * common/macros.inc: Save RAMPZ register if RAMPD is present.
          Add LPM_R0_ZPLUS_FINI macro to restore RAMPZ if RAMPD exists.
        * libc/pmstring/memcmp_PF.S: Restore RAMPZ before return.
        * libc/pmstring/memcpy_PF.S: Same.
        * libc/pmstring/strcasecmp_PF.S: Same.
        * libc/pmstring/strcat_PF.S: Same.
        * libc/pmstring/strcmp_PF.S: Same.
        * libc/pmstring/strcpy_PF.S: Same.
        * libc/pmstring/strlcat_PF.S: Same.
        * libc/pmstring/strlcpy_PF.S: Same.
        * libc/pmstring/strlen_PF.S: Same.
        * libc/pmstring/strncasecmp_PF.S: Same.
        * libc/pmstring/strncat_PF.S: Same.
        * libc/pmstring/strncmp_PF.S: Same.
        * libc/pmstring/strncpy_PF.S: Same.
        * libc/pmstring/strnlen_PF.S: Same.
        * libc/pmstring/strstr_PF.S: Same.

Please review.

(file #29336)

Additional Item Attachment:

File name: restore-rampz.patch            Size:6 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]