[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] [patch #7485] CRC8-CCITT
From: |
Joerg Wunsch |
Subject: |
Re: [avr-libc-dev] [patch #7485] CRC8-CCITT |
Date: |
Fri, 3 May 2013 19:43:35 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
As Frédéric Nadeau wrote:
> Since all three CRC use the same polynomial, here is my proposition to
> cover all three cases:
> - rename to _crc8_update
As there's already another 8-bit CRC (the iButton one), perhaps
_crc8_itu_update? You could add the references for where it is
being used in the comment.
> - Caller shall chose it's initial value(0x00 for simple use and
> CCITT/ITU/ATM or 0xFF for ROHC)
That's the responsibility of the caller anyway, since the header file
only provides update functions.
> - Caller apply xor at the end if needed.
> - Modify doc accordingly
>
> If we agree on that, I'll resubmit a patch asap.
Yes, I think that's fine. Thanks for your work!
--
cheers, Joerg .-.-. --... ...-- -.. . DL8DTL
http://www.sax.de/~joerg/
Never trust an operating system you don't have sources for. ;-)