[avr-libc-dev] [bug #30363] _delay_xx() functions in <util/delay.h> are broken

[Bill Perry]

Follow-up Comment #1, bug #30363 (project avr-libc):

As a followup comment

The define define value for __HAS_DELAY_CYCLES
in the new <util/delah.h> seems backwards.

While it may be ok to set it value to 1 by default in
builtins.h this does not seem appropriate in <util/delay.h>

For backward compability with the older compilers,
<util/delay.h> should not assume the presence of the built in
delay cycles functions.

To be fully backward compatible with the older compilers
the <util/delay.h> needs to define it like this:

#ifndef __HAS_DELAY_CYCLES
#define __HAS_DELAY_CYCLES 0
#endif 

The definition in builtins.h should be different by setting
__HAS_DELAY_CYCLES to 1 as that is the file that defines the compilers builtin
functions, in the absence of the compiler doing itself (like the MIPS version
of GCC does)

--- bill
 

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30363>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/