[avr-libc-dev] [patch #7146] #bug28901 - Xmega header files with missing definitions for GPIO_t and CPU_t

[Eric Weddington]

Follow-up Comment #1, patch #7146 (project avr-libc):

Changes needed to this patch:

- You have accidentally removed the CLK_t structure definition in iox128a1.h.
Please put this back in.

- ChangeLog entry. Please write the word 'ditto' or 'same' to each file that
has the same change as the file above it, see example below. Also each comment
must be a complete sentence, i.e. end it in a period.

--- ChangeLog   (revision 2103)
+++ ChangeLog   (working copy)
@@ -1,3 +1,23 @@
+2010-03-31  Anitha Boyapati <address@hidden>
+
+       Fix bug #28901.
+       * include/avr/iox128a1.h - Removed GPIO and CPU memory map entries.
+       * include/avr/iox128a1u.h - Same.
+       * include/avr/iox128a3.h - Same.
+       * include/avr/iox128d3.h - Same.
+       * include/avr/iox16a4.h - Same.
+       * include/avr/iox16d4.h - Same.
+       * include/avr/iox192a3.h - Same.
+       * include/avr/iox192d3.h - Same.
+       * include/avr/iox256a3.h - Same.
+       * include/avr/iox256a3b.h - Same.
+       * include/avr/iox256d3.h - Same.
+       * include/avr/iox32a4.h - Same.
+       * include/avr/iox32d4.h - Same.
+       * include/avr/iox64a1.h - Same.
+       * include/avr/iox64a3.h - Same.
+       * include/avr/iox64d3.h - Same.
+

- You also need to make the changes to iox64a1u.h.

- In the NEWS entry, the description of the bug is the "Summary" field
description on the bug report, so instead of this:

--- NEWS        (revision 2103)
+++ NEWS        (working copy)
@@ -108,6 +108,7 @@
   [#28688] using_tools.dox fails to build due to extra underscore
   [#28756] Bug in AVR libc 1.6.7 (power.h for 8-bit AVR)
   [#28812] iotn48.h TWS# bits off by one
+  [#28901] iox*.h are modified as a part of bug28901 fix


It should be this:

--- NEWS        (revision 2103)
+++ NEWS        (working copy)
@@ -108,6 +108,7 @@
   [#28688] using_tools.dox fails to build due to extra underscore
   [#28756] Bug in AVR libc 1.6.7 (power.h for 8-bit AVR)
   [#28812] iotn48.h TWS# bits off by one
+  [#28901] Xmega header files are missing definitions for GPIO_t and CPU_t


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7146>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/