[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[avr-libc-dev] RE: [bug #25300] Additional i/o port names
From: |
Weddington, Eric |
Subject: |
[avr-libc-dev] RE: [bug #25300] Additional i/o port names |
Date: |
Mon, 30 Mar 2009 18:05:17 -0600 |
> -----Original Message-----
> From: Frédéric Nadeau [mailto:address@hidden
> Sent: Monday, March 30, 2009 12:42 PM
> To: Frédéric Nadeau; Weddington, Eric; address@hidden
> Subject: [bug #25300] Additional i/o port names
>
>
> Follow-up Comment #3, bug #25300 (project avr-libc):
>
> I have attaced a newly generated patch against HEAD
>
> vector now have number in the following format:
> XXXXX_vect_num 4
> XXXXX_vect _VECTOR(4)
>
> pin definition looks like:
> #define XX_DDR DDRD
> #define XX_PORT PORTD
> #define XX_PIN PIND
> #define XX_BIT 5
>
> Patch to the xml folder is also included. This has helped to
> generate the new
> io header and I don't beleived it is used for anything else.
Impressive work! It's going to take some time for me to review a > 24000 line
patch. ;-)
One thing that I spotted so far:
+#define ADc5_DDR DDRA
+#define ADc5_PORT PORTA
+#define ADc5_PIN PINA
+#define ADc5_BIT 5
This is for include/avr/iom8535.h. Note the lowercase 'c' in the name above,
which should be uppercase. This could be due to bad data in the XML file; it's
certainly known that these XML files are not perfect. In those cases, you may
have to manually fix the patch, and send an email to avr AT atmel DOT com and
request that they fix the XML file. Please CC me on those emails so I can
follow up on those. (Thanks!)
As I mentioned, this is going to take some time. Give me a couple of days to go
through this.
Eric
- [avr-libc-dev] [bug #25300] Additional i/o port names, Frédéric Nadeau, 2009/03/26
- [avr-libc-dev] [bug #25300] Additional i/o port names, Frédéric Nadeau, 2009/03/30
- RE: [avr-libc-dev] [bug #25300] Additional i/o port names, Ron Kreymborg, 2009/03/30
- [avr-libc-dev] [bug #25300] Additional i/o port names, Eric Weddington, 2009/03/30
- [avr-libc-dev] RE: [bug #25300] Additional i/o port names,
Weddington, Eric <=
- [avr-libc-dev] Re: [bug #25300] Additional i/o port names, Frédéric Nadeau, 2009/03/30
- RE: [avr-libc-dev] Re: [bug #25300] Additional i/o port names, Weddington, Eric, 2009/03/31
- Re: [avr-libc-dev] Re: [bug #25300] Additional i/o port names, Frédéric Nadeau, 2009/03/31
- RE: [avr-libc-dev] Re: [bug #25300] Additional i/o port names, Weddington, Eric, 2009/03/31