Re: [avr-libc-dev] Avrlibc and lcd.c

[edward baafi]

Hi Joerg,

I hacked your LCD code a day before going on a trip so sorry it took
so long to get back..

So I have a question..  I believe that the new code (separate ports
definitions for control and data) is backward compatible with code
written for a single port but I don't have any larger micros to test
on..  I think this will be useful for others and don't mind hacking
the documentation but am not sure if you can put it up if not tested
on a single port..  I could just add a section of the documentation
where I link to the new code and state that it has been tested on the
mega88 but still leave your original in tact..  What do you think?

Thanks,
Ed Baafi

On 10/15/07, Joerg Wunsch <address@hidden> wrote:
> As edward baafi wrote:
>
> > Ok..  The author is Joerg Wunsch and the document is here:
>
> It's actually example code, rather than meant to be a really universal
> LCD driver.  But yes, I tried to make it flexible enough so someone
> else (or even myself :) could reuse it for a real-world project as
> well.  Actually, it grew out of a private project of mine (that never
> materialized to completeness so far).
>
> As you cc'ed me, you already did what Eric suggested...
>
> I'm fine if you want to do the work to divide the data and control
> ports (and I don't see an immediate technical reason why this would
> not be possible), as long as
>
> . you don't break the existing setup with this, and
>
> . you not only hack the code but also update the respective part
>   of the documentation.
>
> The second requirement is simply there since it usually costs at least
> the same amount of time to properly document some piece of code as it
> took to write the code itself (in particular within an example project
> that is intended for others being able to follow it).  Patches that
> only patch the code tend to hang around in the patch tracker virtually
> forever as nobody will find the time to spend to eventually add the
> missing documentation.
>
> --
> cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL
>
> http://www.sax.de/~joerg/                        NIC: JW11-RIPE
> Never trust an operating system you don't have sources for. ;-)
>