[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AW: [avr-libc-dev] eeprom_read_word causes problems for the compiler

From: Wouter van Gulik
Subject: Re: AW: [avr-libc-dev] eeprom_read_word causes problems for the compiler
Date: Mon, 15 Oct 2007 14:25:07 +0200
User-agent: Thunderbird (Windows/20070728)

Haase Bjoern (PT/EMM1) schreef:
Yes I will try to put together a patch with the minimal changes. I only
to know one thing; can I assume that using this construction:

/** \ingroup avr_eeprom
   Read one 16-bit word (little endian) from EEPROM address \c addr.
eeprom_read_word (const uint16_t *addr)
 register uint16_t result asm("r24"); //I can specify r24 only

 __asm__ __volatile__ (
       XCALL " __eeprom_read_word_" _REG_LOCATION_SUFFIX CR_TAB
      : "+x" (addr),
        "=w" (result) //Use w restrict to adiw capable registers
      : );
 return result;

I fear that this will not be guaranteed to be correct! The compiler
might reorder code and might be tempted to optimize away your result
variable so that it could be placed in another register. The dangerous
thing is, that your code might work sometimes!

I found even more "prove":

"Sometimes you need to make an asm operand be a specific register, but there's no matching constraint letter for that register by itself. To force the operand into that register, use a local variable for the operand and specify the register in the variable declaration. See Explicit Reg Vars. Then for the asm operand, use any register constraint letter that matches the register:
     register int *p1 asm ("r0") = ...;
     register int *p2 asm ("r1") = ...;
     register int *result asm ("r0");
     asm ("sysint" : "=r" (result) : "0" (p1), "r" (p2));"

So I think it's perfectly legal to do what I wanted to do.

I checked the documentation, this feature is documented back to at least 2.9.5. Did AVR even existed in GCC back then? If not it will not causes a problem for users building avr-libc with an older version of GCC
The 2.9.5 documentation:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]