avr-libc-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] vfscanf.c namespace clash and paren warning


From: Joerg Wunsch
Subject: Re: [avr-libc-dev] vfscanf.c namespace clash and paren warning
Date: Sat, 3 Apr 2004 23:04:26 +0200
User-agent: Mutt/1.2.5i

As Theodore A. Roth wrote:

> > I don't object, but don't particularly like the idea of a leading
> > underscore either.  Maybe renaming them to something more descriptive
> > is better?  I don't have a good idea about a better name thoug.

> Yeah, I didn't really like it either, but I couldn't think of a better
> name myself.

scanf_set_bit, and scanf_bit_is_set?

> > That actually fixes a bug. :-o

> I guess I got the parens in the right spot then. ;-)

Yeah, and the compiler was totally right to warn it.  Stupid me that I
didn't spot that warning.  (But there's way too much compilation output
anyway.)

> Are these ok for 1.0 branch too?

By all means, yes!
-- 
J"org Wunsch                                           Unix support engineer
address@hidden        http://www.interface-systems.de/~j/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]