[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] Fixed various minor bugs

From: eric
Subject: Re: [avr-libc-dev] Fixed various minor bugs
Date: Mon, 16 Feb 2004 00:42:01 GMT

> On Sun, 15 Feb 2004, Joerg Wunsch wrote:
> > As Theodore A. Roth wrote:
> >
> > > Please post all patches committed to the 1.0 branch 
to the list.
> >
> > Does really anyone read that?
> I do. Also, it gives anyone on the list a chance to 
review any changes
> made to the stable branch. All changes on the stable 
branch should be
> reviewed by at least the other developers. If now one 
takes the time to
> review the patches, they can't complain if it broke 
something when we
> make the release and they'll just have to wait for the 
next release.
> >
> > Alas, subversion.gnu.org's CVS server command doesn't 
handle date
> > specifications together with branch specifications (-
jbranch:date) in
> > cvs diff or cvs update operations.  This makes it 
really cumbersome to
> > reconstruct a diff like this one. :-(  Remote rsync is 
no longer
> > supported either, so I can't do this locally anymore.  
Performing a
> > bunch of cvs log/cvs diff operations remotely over ssh 
is quite
> > annoying.
> If you do a 'cvs diff -u > foo.diff' just before doing 
the commit, you
> don't have to jump through hoops to pull out the diffs. 
It also gives
> you a chance to review the patch yourself before the 
commit. I've caught
> many stupid mistakes (like docu typos, etc) by doing 
this. Once you've
> done this, it only takes a few seconds to post it to the 
list after
> you've made the commit.
> >>From there, it's also a trivial step to wrap the cvs 
diff command to
> automate generating a patch with a ChangeLog entry stub 
ready to be
> filled in. I've posted my wrapper script a few times 
> Posting the patch also gives those who don't want to deal 
with cvs a
> chance to review the patch without having to dig through 
cvs to figure
> out what was changed.

In essence I agree with all the above.

However, I wanted to point out that for those who don't 
like dealing with CVS directly, viewing the project CVS via 
the web interface is actually very easy... Well, as long as 
there's a Changelog entry it's pretty easy to go through 
what's changed, including a colorized diff between two 
revisions of a file.... YMMV.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]