[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] [PATCH] two small header patches for more unification
From: |
Stephan Linz |
Subject: |
Re: [avr-libc-dev] [PATCH] two small header patches for more unification |
Date: |
Sun, 19 Oct 2003 20:16:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:0.9.8) Gecko/20020204 |
Theodore A. Roth wrote:
On Sun, 19 Oct 2003, Stephan Linz wrote:
Hi all,
last week I've seen the preparing work for 1.0.1 release of avr-libc.
Time to post two small patches I've made for more than one year and used
in my CDK4AVR project. Look into the patches -- I think it's
self-explanatory, but discussion will be wellcome.
(patch IDs 2106 and 2107 at
http://savannah.nongnu.org/patch/?group=avr-libc or attachment)
Thanks Stephan.
The iom162 fix is already in 1.0.1. (Note that you missed the PE1 -> UPE1
change. ;-)
Oops.
I posted a patch to clean up port pins defs and move the generic defs out of
Yes of course, I've read the long bug #5799 discussion after my post --
sorry.
iom128.h into portpins.h. That patch is going to go into 1.0.2 since it
masks the change to iom162.h (PE0, PE1). I'd rather see 1.0.1 give a compile
error for mega162 users using PE0 or PE1 to give them a chance to change it
to UPE0 or UPE1. I will be making iom162.h issue a compiler warning when
using the PE0 or PE1 to help ease the transition.
I'll add your SREG_* defs to my patch.
Your changes to timers.h will have to go into 1.0.2. I need to think about
that more and cross check it with some other device datasheets, but don't
have time to do that before I roll the 1.0.1 today.
Hmm. I think the handling will become not so trivial, because only
Timer0 clock select bit definitions of ATmega128 differs. Timer[1-3]
are equal to Timer0 of all other AVR devices. So it is too simple and
dowdy only change the defines for ATmega128. We need more complex macros
to distinguish between AVR device and timer enumeration. I'm thinking too.
Stephan
--
___________________________________________________________________
| - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - |
| *_ Stephan Linz |
| / \ mailto:address@hidden |
| ~^~ http://www.li-pro.net (final release in Dec. 2002) |
| _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ |
-------------------------------------------------------------------