[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] (Fwd) WinAVR 20030424
From: |
Theodore A. Roth |
Subject: |
Re: [avr-libc-dev] (Fwd) WinAVR 20030424 |
Date: |
Mon, 5 May 2003 09:46:44 -0700 (PDT) |
On Mon, 5 May 2003, E. Weddington wrote:
:) > > {
:) > > #if defined(EIMSK)
:) > > EIMSK = ints;
:) > > #elif defined(GIMSK)
:) > > GIMSK = ints;
:) > > #elif defined(GICR)
:) > > GICR = ints;
:) > > #else
:) > > # error "No valid external interrupt control register defined."
:) > > #endif
:) > > }
<snip>
:) But in the meanwhile, as a stopgap, can we change the #error to
:) #warning? Or just drop that branch and let it compile to nothing;
:) it's harmless if those registers aren't defined.
It's an error since the header isn't handling something correctly.
Doing nothing is wrong. The user expects something to happen when they
use the interface and silently doing nothing breaks their program. I
made it an #error to help flush out unhandled cases (and it seems to
have worked).
Ted Roth