[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avr-libc-dev] io.h re-org
From: |
E. Weddington |
Subject: |
Re: [avr-libc-dev] io.h re-org |
Date: |
Mon, 06 Jan 2003 11:27:05 -0700 |
On 5 Jan 2003 at 21:40, Joerg Wunsch wrote:
> As Joerg Wunsch wrote:
>
> > > The patch looks good, but it's too much at once. My plan (when I
> > > got around to it) was to do something similar but in small,
> > > incremental steps.
> >
> > > It's a pain, but it makes review much easier. It's not much fun
> > > trying to review a 2500 line diff and grok everything it does. ;-)
> >
> > OK, another idea. Instead of reviewing the 2500 line diff, just
> > review the effect it has on compiled programs. :)
> >
> > At least the technical correctness can be verified by comparing the
> > preprocessor symbols resulting from the inclusion of <avr/io.h>
> > before and after the change. This can easily be automated by using
> > avr-gcc -E -dM, run on a simple .S file that is almost empty except
> > of the
> > #include <avr/io.h> line.
>
> Could we eventually agree on this issue? I've proven technical
> correctness of the patch, and i rather wouldn't like to have done all
> this in vain.
>
My 2 cents: The sooner this can be done, the sooner it can be tested
by the community before a 1.0 release.
Eric