[avr-libc-dev] [Bug #2111] Enhancement of code in sfr_defs.h

[nobody]

=================== BUG #2111: LATEST MODIFICATIONS ==================
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=2111&group_id=2140

Changes by: Joerg Wunsch <address@hidden>
Date: 2003-Jan-06 23:01 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Fixe applied in revision 1.7 of include/avr/sfr_defs.h.

Thanks for the fix!



=================== BUG #2111: FULL BUG SNAPSHOT ===================


Submitted by: None                      Project: AVR C Runtime Library          
Submitted on: 2003-Jan-02 18:36
Category:  Header                       Severity:  5 - Major                    
Bug Group:  None                        Resolution:  Fixed                      
Assigned to:  joerg_wunsch              Originator Email:  address@hidden
Status:  Closed                         

Summary:  Enhancement of code in sfr_defs.h

Original Submission:  In  sfr_defs.h, the bit_is_clear macro is declared as 
follow:
#define bit_is_clear(sfr, bit) (~inb(sfr) & _BV(bit))
  
 If I watch code generated by compiler, the code is not sufficient. But 
with this macro the size of code is decreazed (I ve just tested that on atmega 
target).
 
#define bit_is_clear(sfr,bit)   !bit_is_set(sfr,bit)
 
Have you the same results and do you think it's interesting to replace the old 
version with this version ?

Best regards

Frantz




Follow-up Comments
*******************

-------------------------------------------------------
Date: 2003-Jan-06 23:01             By: joerg_wunsch
Fixe applied in revision 1.7 of include/avr/sfr_defs.h.

Thanks for the fix!


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=2111&group_id=2140