avr-libc-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] Why include <ina90.h> from <avr/pgmspace.h>?


From: Joerg Wunsch
Subject: Re: [avr-libc-dev] Why include <ina90.h> from <avr/pgmspace.h>?
Date: Sun, 6 Oct 2002 23:54:08 +0200
User-agent: Mutt/1.2.5i

As Joerg Wunsch wrote:

> Would anybody moan if i removed this line completely?  Otherwise,
> i might encapsulate it into some #ifdef magic, but i feel that
> to be ugly.

Sigh.  It's not quite that easy.  Further definitions rely on
the definitions from ina90.h.  So i suggest the following.  It
also changes all non-compat internal definitions to use two
prepended underscores.

Still, user programs need to include <avr/io.h> before in order
to define RAMPZ.  This is only actually needed when ELPM is used,
so my stdio stuff won't stumple across it.  Anyway, in Ted's course
of centralizing the common declarations of the various ioXXXX.h
files, RAMPZ should probably be declared based on the architecture
flag (avr5?) as opposed to based on the actual MCU type.  That way,
library code code still include <avr/io.h> and get some useful
definitions whithout the requirement to explicitly specify an MCU
type.  This would also help eliminating the magic numbers for the
SP_L/SP_H registers in malloc.c.
-- 
J"org Wunsch                                           Unix support engineer
address@hidden        http://www.interface-systems.de/~j/

Attachment: avr-include.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]