[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[avr-libc-dev] Re: [avr-gcc-list] [patch] avr-libc ATmega128 include fil
Theodore A. Roth
[avr-libc-dev] Re: [avr-gcc-list] [patch] avr-libc ATmega128 include file
Mon, 26 Aug 2002 10:58:04 -0700 (PDT)
I think this particular change is wrong:
@@ -318,10 +319,9 @@
/* USART0 Control and Status Register C */
#define UCSR0C _SFR_MEM8(0x95)
-/* USART1 Baud Rate Register High */
+/* USART1 Baud Rate Register */
+#define UBRR1 _SFR_MEM16(0x98)
#define UBRR1H _SFR_MEM8(0x98)
-/* USART1 Baud Rate Register Low*/
#define UBRR1L _SFR_MEM8(0x99)
/* USART1 Control and Status Register B */
Atmel fsck'd this one. If you look close, you'll see that it's big
endian, when all the other high/low register combos are little endian.
Thus, I don't think the usage of _SFR_MEM16() is appropriate here.
I think the attached patch is safe to commit.
The rest of Svein's patch I will look at separately once this is
committed. (His patch moves a lot of stuff around and I just want more
time to digest it before I commit it ;-)
On Mon, 26 Aug 2002, Svein E. Seldal wrote:
:) I've updated the include/avr/iom128.h file to have all the bits and port
:) definitions found in the latest ATmega128 datasheet.
:) 2002-08-26 Svein E. Seldal <address@hidden>
:) * include/avr/iom128.h: Updated include definitions
:) against the latest datasheet from Atmel.
Description: Text document
|[Prev in Thread]
||[Next in Thread]|
- [avr-libc-dev] Re: [avr-gcc-list] [patch] avr-libc ATmega128 include file,
Theodore A. Roth <=