[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] "make dist" did not depend on $(BUILT_SOURCES)
From: |
Nick Bowler |
Subject: |
Re: [PATCH] "make dist" did not depend on $(BUILT_SOURCES) |
Date: |
Tue, 28 Nov 2017 15:45:30 -0500 |
User-agent: |
NeoMutt/20171027 |
Hi Jim,
On 2017-11-28 11:21 -0800, Jim Meyering wrote:
> Date: Thu, 20 Mar 2014 12:31:32 -0700
> Subject: [PATCH] "make dist" did not depend on $(BUILT_SOURCES)
>
> * lib/am/distdir.am (distdir-am): New intermediate target.
> Interpose this target between $(distdir) and its dependency
> on $(DISTFILES), so that we can ensure $(BUILT_SOURCES) are
> all created before we begin creating $(DISTFILES).
[...]
> NEWS | 3 +++
> lib/am/distdir.am | 7 ++++--
> t/dist-vs-built-sources.sh | 56
> ++++++++++++++++++++++++++++++++++++++++++++++
> t/list-of-tests.mk | 1 +
> 4 files changed, 65 insertions(+), 2 deletions(-)
> create mode 100644 t/dist-vs-built-sources.sh
The Automake manual unequivocally states that BUILT_SOURCES files are
generated only when running 'make all', 'make check' or 'make install'.
So if they are going to be generated on 'make dist' as well, then the
manual needs a corresponding update.
Otherwise this looks like a useful improvement.
Cheers,
Nick