[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] port elisp-compilation support to emacs-23.1 and newer
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH] port elisp-compilation support to emacs-23.1 and newer |
Date: |
Fri, 24 Nov 2017 00:57:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello Jim,
Jim Meyering <address@hidden> writes:
> On Thu, Nov 23, 2017 at 7:38 AM, Jim Meyering <address@hidden> wrote:
>> I wanted to make a new idutils release, but was blocked because
>> its "make distcheck" would fail. That was because it distributes
>> and builds from an elisp file, and automake's elisp-compilation
>> rule uses a function that was marked obsolete back in 2009.
>> Upstream Emacs finally removed support for that function in May,
>> so anyone using emacs built since then will see the same failure
>> I saw. It also strikes whenever building from a read-only source
>> directory.
>>
>> This change switches the build command to use the "new" way.
>>
>> I started discussion on emacs-devel last night:
>> https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00551.html
>>
>>
>> From ecad5844100d5193ecd58f66f31f6bbf0ef04e23 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Wed, 22 Nov 2017 21:07:29 -0800
>> Subject: [PATCH] port elisp-compilation support to emacs-23.1 and newer
>>
>> In May of 2017, support for using the long-deprecated
>> byte-compile-dest-file function was removed, and that removal broke
>> automake's elisp-compiling rule for any .el file not in the current
>> directory. In emacs-23.1 (July 2009) byte-compile-dest-file-function
>> became the recommended way to adjust the byte-compiler's destination.
>> * lib/am/lisp.am (.el.elc): Use byte-compile-dest-file-function,
>> rather than byte-compile-dest-file.
>> * t/lisp-readonly-srcdir.sh: New file, to test for the above.
>> * t/list-of-tests.mk (handwritten_TESTS): Add it.
>
> Pushed to the micro branch:
>
> https://git.savannah.gnu.org/cgit/automake.git/commit/?h=micro&id=9182df7e4810a411147d523de8cd141e749c5e39
With the "recent" change in Automake branch naming scheme, 'master'
seems a better fit for this:
https://lists.gnu.org/archive/html/bug-automake/2017-09/msg00015.html
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Re: [PATCH] port elisp-compilation support to emacs-23.1 and newer, Glenn Morris, 2017/11/27