[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: perl ithreads support: why hardcode at configure time ?
From: |
Mike Frysinger |
Subject: |
Re: perl ithreads support: why hardcode at configure time ? |
Date: |
Sat, 12 Jan 2013 00:06:33 -0500 |
User-agent: |
KMail/1.13.7 (Linux/3.7.1; KDE/4.6.5; x86_64; ; ) |
On Friday 11 January 2013 12:21:24 Stefano Lattarini wrote:
> On 01/11/2013 06:11 PM, Mike Frysinger wrote:
> > On Friday 11 January 2013 04:08:26 Stefano Lattarini wrote:
> >> On 01/11/2013 05:07 AM, Mike Frysinger wrote:
> >>> i can't imagine this is a big runtime penalty, so why does configure
> >>> check for the perl's thread settings and then hardcode that in the
> >>> generated automake ?
> >>
> >> I don't know, I wasn't around when the change was introduced. You'll
> >> have to dig out the archives; if we don't find any compelling reason
> >> for having the check at configure time rather than runtime, I agree
> >> your change is a nice simplification ...
> >
> > i couldn't find references to ithreads in the automake or
> > automake-patches archives
>
> I only found an explanation of why "require ...; import ..." was used
> instead of a simpler "use ...", but as for you, I was unable to find out a
> rationale for having threading support checked at configure time. So I
> say we apply your proposed change, and reconsider it only if something
> breaks or someone complains.
ok, i'll clean it up and send it out. also realized i forgot to `git pull`
(was like 900 commits behind) before writing the previous code so that patch
has no hope of applying to current master :).
-mike
signature.asc
Description: This is a digitally signed message part.