[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Request for Review
From: |
NightStrike |
Subject: |
Request for Review |
Date: |
Thu, 22 Nov 2007 02:03:07 -0500 |
I'm getting pretty finalized on the automake build system for my
project. I was wondering, however, if anyone would mind going over
the configure.ac and Makefile.am files to proofread them and give any
suggestions, for instance if you see a better way to do things or if
it should be formatted differently. I'm very open to all of your
suggestions, and would appreciate it. Here's a link to the
latest versions:
http://mingw-w64.svn.sourceforge.net/viewvc/mingw-w64/trunk/mingw-w64-crt/
Also, I am doing a bunch of tests in configure.ac that I don't think
are necessary. autoscan put them in there, and I commented a bunch
out. For instance:
60 #AC_HEADER_DIRENT
61 #AC_HEADER_STDC
62 #AC_CHECK_HEADERS([fcntl.h fenv.h float.h inttypes.h limits.h
locale.h malloc.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h
sys/time.h sys/timeb.h termios.h unistd.h wchar.h wctype.h])
65 AC_C_INLINE
66 AC_TYPE_INT32_T
67 AC_TYPE_PID_T
68 AC_TYPE_SIZE_T
69 AC_HEADER_TIME
70 AC_TYPE_UINT32_T
71 AC_C_VOLATILE
72 AC_CHECK_TYPES([ptrdiff_t])
75 AC_FUNC_MALLOC
76 #AC_FUNC_MBRTOWC
77 #AC_FUNC_REALLOC
78 #AC_FUNC_STRTOD
79 #AC_FUNC_VPRINTF
80 #AC_CHECK_FUNCS([alarm atexit btowc fesetround floor ftruncate
gettimeofday isascii localeconv mbrlen memmove memset pow rint
setlocale sqrt strcasecmp strchr strncasecmp strtoull strtoumax])
I think that those macros are checking for the existance of those
functions on the build system, and since I am making a runtime for a
host system, they may not apply? I think that those functions are
built by the mingw-w64 project, yes? Does that make sense? I think I
should remove them all, but I'm not sure. I'd like an expert opinion
on the matter.
- Request for Review,
NightStrike <=