Re: register_language() ?

[Pavel Roskin]

Hello, Patrick!

> I just did a cvs checkout of automake, all the tests pass, but believe it
> or not:

In fact, installsh.test fails, but it's an _expected_ failure.

I'm probably missing something, since I have no time to catch up with
the mailing list, but what's wrong with the forward declarations, as
described in "man perlsub"?

This patch has been tested with Perl perl5.005_03 and 5.6.0. Ok to apply?

ChangeLog:

        * automake.in: Add a forward declaration for register_language().
        * tests/Makefile.am (XFAIL_TESTS): Remove installsh.test - it
        passes now.

__________________________
--- automake.in
+++ automake.in
@@ -603,6 +603,13 @@
 # FIXME: This is a hack. a better switch should be found.
 my $get_object_extension_was_run;

+
+## --------------------------------- ##
+## Forward subroutine declarations.  ##
+## --------------------------------- ##
+sub register_language ($%);
+
+
 # &initialize_per_input ()
 # ------------------------
 # (Re)-Initialize per-Makefile.am variables.
--- tests/Makefile.am
+++ tests/Makefile.am
@@ -2,14 +2,7 @@

 AUTOMAKE_OPTIONS = gnits

-# installsh.test
-# Currently Perl 5.6 complains because register_language is used before
-# being defined.  It's only a warning, and this warning will be naturally
-# solved later (either when we move register_language, or when Languages
-# are actual classes, not objects).  But installsh checks automake's
-# stderr, which includes these complaints from Perl.
-# So just forget about it now.
-XFAIL_TESTS = installsh.test man.test objc.test subobj2.test yaccvpath.test
+XFAIL_TESTS = man.test objc.test subobj2.test yaccvpath.test

 TESTS =        \
 acinclude.test \
__________________________

-- 
Regards,
Pavel Roskin