Re: 28-variable-cleanups.patch

[Tom Tromey]

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

This is mostly ok.

Akim>   * automake.in (&variable_conditionally_defined): Rename as...
Akim>   (&variable_unconditionally_defined): this.

Please make sure your ChangeLog entries are accurate.
This entry is wrong.

Akim>   (&variable_dump): Fix the output.
Akim>   (&variable_defined, &variable_define): Since conditions are
Akim>   canonicalized, don't use a loop to look for a condition: read the
Akim>   hash.
Akim>   (&variable_define, &rule_define, &read_am_file, &file_contents):
Akim>   Rename $cond_string as $cond.
Akim>   * distdir.am (PACKAGE, VERSION): Comment out.
Akim>   Since they are already discovered via AC_SUBST, they now trigger a
Akim>   `defined twice' error.

Don't comment them out, just delete them.

With those changes this is ok.

Tom