Re: [PATCH] aclocal: add --aclocal-path option to override $ACLOCAL_PATH

[Karl Berry]

Hi Mike,

    * bin/aclocal.in: Add --aclocal-path to override ACLOCAL_PATH.

FWIW, looks almost fine to me.

1) Please add NEWS entry.

2) If you're up for it, please add a test.  I confess I did not test
it. If you don't feel like it's necessary here, that's ok by me.

3) One tweak to the new help text:

    +      --aclocal-path=DIR    directory holding third-party local files

directory holding -> path in which to look for
(or something along those lines)

.. since it's a path not a directory. I realize you originally proposed
a directory, and that would be consistent with the related options.  But
since the purpose of this option is to override the envvar, I think it
is better for it (the option) to behave just like the envvar.

(For future reference: some discussion at
https://lists.gnu.org/archive/html/automake/2022-01/msg00005.html)

     @subsubheading Planned future incompatibilities

It's a different topic, but I certainly would advocate against making
such change as described here, for all the usual reasons. So it's not
"planned" any more, as far as I'm concerned, and I'd probably tone down
the expectations as written. --thanks, karl.