Re: preparing for a new release

[Gavin Smith]

On Sun, Nov 15, 2020 at 09:45:44AM -0800, Jim Meyering wrote:
> I've fixed a few of these failures, but here is still at least one
> that I have not fixed: t/txinfo-no-clutter. In this case, running it
> with no parallelism and by itself passes:
>   make -k check TESTS='t/txinfo-no-clutter'
> Yet running it with parallel make fails (I'm using make-4.3.90 built
> from git, in case it matters):
>   make -k check TESTS='t/txinfo-no-clutter' AM_TESTSUITE_MAKE="make
> -j$(( 2*$(nproc) + 1 ))"
> 
> Not sure I'll work more on this today, so sharing: The attached log
> shows that this fails when building that test's final "all" rule,
> often because a .dvi file could not be found:
> 
> ) localization,mv: cannot stat 'bar.dvi': No such file or directory

My suspicion is that it is interference between the dvi and ps targets.
When I remove the ps targets with the change at the bottom of this email,
the test passes every time.  The ps file is made from the dvi file so
perhaps the ps rules are deleting the dvi file while the dvi rules are
still using it, or vice versa.

diff --git a/t/txinfo-no-clutter.sh b/t/txinfo-no-clutter.sh
index b311f0348..4701462d2 100644
--- a/t/txinfo-no-clutter.sh
+++ b/t/txinfo-no-clutter.sh
@@ -26,7 +26,7 @@ AC_OUTPUT
 END
 
 cat > Makefile.am << 'END'
-all-local: ps pdf dvi html # For "make distcheck".
+all-local: pdf dvi html # For "make distcheck".
 info_TEXINFOS = foo.texi doc/bar.texi baz.texi
 SUBDIRS = sub
 END
@@ -34,7 +34,7 @@ END
 mkdir sub doc
 
 cat > sub/Makefile.am << 'END'
-all-local: ps pdf dvi html # For "make distcheck".
+all-local: pdf dvi html # For "make distcheck".
 info_TEXINFOS = baz.texi
 END
 
@@ -90,7 +90,7 @@ $AUTOCONF
 
 # Try one by one, to ensure later targets don't involuntarily
 # clean up potential cruft left by earlier ones.
-for fmt in info pdf ps dvi html all; do
+for fmt in info pdf dvi html all; do
   $MAKE $fmt
   # For debugging.
   ls -l . doc sub
@@ -103,7 +103,7 @@ for fmt in info pdf ps dvi html all; do
       test -e sub/baz.html
       ;;
     all)
-      for x in info pdf ps dvi; do
+      for x in info pdf dvi; do
         test -f foo.$x
         test -f doc/bar.$x
         test -f baz.$x
@@ -127,10 +127,9 @@ for fmt in info pdf ps dvi html all; do
   case $fmt in
     pdf) extension_rx="(texi|pdf|t2p)";;
     dvi) extension_rx="(texi|dvi|t2d)";;
-     ps) extension_rx="(texi|ps|dvi|t2d)";;
    info) extension_rx="(texi|info)";;
    html) extension_rx="(texi|html)";;
-    all) extension_rx="(texi|html|info|pdf|ps|dvi|t2[pd])";;
+    all) extension_rx="(texi|html|info|pdf|dvi|t2[pd])";;
       *) fatal_ "unreachable code reached";;
   esac
   $EGREP -v "^$basename_rx\.$extension_rx$" lst && exit 1