automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite


From: Stefano Lattarini
Subject: Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite
Date: Mon, 14 Jan 2013 22:53:28 +0100

On 01/14/2013 09:26 PM, Eric Blake wrote:
> On 01/12/2013 05:51 AM, Stefano Lattarini wrote:
>> Instead, only touch up AC_PROG_CC to distribute the 'compile' script and
>> to rewrite $CC if a losing compiler is detected.
> 
> That reads poorly - I first parsed it as "if losing compiler, then
> (distribute the 'compile' script and rewrite $CC)"; when you really
> intend "always distribute 'compile' script, and (if losing compiler,
> rewrite $CC)".  Try this wording:
> 
> Instead, just touch up AC_PROG_CC to rewrite $CC when a losing compiler
> is detected, and to always distribute the 'compile' script.
> 
Done, thanks.

Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]