automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use runtime (not configure time) detection of perl threads


From: Stefano Lattarini
Subject: Re: [PATCH] use runtime (not configure time) detection of perl threads
Date: Sat, 12 Jan 2013 12:32:42 +0100

On 01/12/2013 06:19 AM, Mike Frysinger wrote:
> I can't imagine the runtime checks being a big runtime penalty, so there
> shouldn't be a need to do the checks at configure check and hardcode the
> result in the generated automake.
> 
> With the current system, it means if you change your perl config (build
> perl w/threads, build automake, build perl w/out threads), or deploy a
> compiled automake package on a different system (build had threads, but
> deployed system does not), you get errors when trying to run automake.
> 
> So take the logic from configure.ac and move it to the one place where
> PERL_THREADS is used (lib/Automake/Config.in) and do the version/config
> checking at runtime.
> 
> Signed-off-by: Mike Frysinger <address@hidden>
> 
Thanks.

I've tested the patch with perl 5.6, and it seems to work fine.

So I've applied to maint (after tweaking the summary line to make it
more conforming to our standards, and moving the S-o-b at the end of
the commit message).

Best regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]