Re: [PATCH 2/2] ylwrap: various fixes

[Akim Demaille]

Le 21 déc. 2012 à 18:43, Stefano Lattarini <address@hidden> a écrit :

> On 12/21/2012 06:31 PM, Akim Demaille wrote:
>> 
>>> Since you have a very good
>>> explanation of such a "why" (as seen in the NEWS file), would you
>>> mind reporting it (at least in an abridged form) in the commit message
>>> as well?
>> 
>> If you think it's useful, I sure can.
>> 
> I think it is.  In fact, I find your new commit message a vast
> improvement. module few nits inlined below (please don't hate
> me  for all this pickiness).

:) :) :)

Not now that we can rejoice that the world has not come to an end.

>>    ylwrap: various fixes
>> 
>>    rename properly header guards in generated header files, instead of
>> 
> Missing capitalization at the beginning of the sentence.
> 
>>    leaving Y_TAB_H.
>> 
>>    convert header guards in implementation files.  Because ylwrap failed
>> 
> Likewise.
> 
>>    to rename properly #include in the implementation files, current
>>    versions of Bison (e.g., 2.7) duplicate the generated header file in
>>    the implementation file.  The header guard then protects the
>>    implementation file from duplicate definitions from the header file.
>> 
>>    generate header guards with a single '_' for series of non alphabetic
>> 
> Likewise.
> 
>>    characters, instead of several.  This is what Bison does.
>> 
>>    Fixes t/yacc-d-basic.sh.
>> 
> Or "Makes the test 't/yacc-d-basic.sh' pass again"

Did all that.

>> @@ -206,6 +218,12 @@ New in 1.13:
>>   - Support for tcc (the Tiny C Compiler) has been improved, and is now
>>     handled through a dedicated 'tcc' mode.
>> 
>> +* The ylwrap script:
>> +
>> +  - ylwrap generates header guards with a single '_' for series of non
>> +    alphabetic characters, instead of several.  This is what Bison
>> 
> s/Bison/Bison >= 2.7/ maybe?
> 
> The rest of the patch seems OK.  Thanks for taking care of this.

Updated and pushed as "ylwrap-fixes".  Feel free to tweak,
push etc.  I'll be afk.

Best wishes for Christmas!