automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add action arguments to AM_PROG_VALAC


From: Stefano Lattarini
Subject: Re: add action arguments to AM_PROG_VALAC
Date: Thu, 27 Sep 2012 11:13:18 +0200

On 09/11/2012 11:34 AM, Daiki Ueno wrote:
> Hi,
>
Hi Daiki, and sorry for the shameful delay.

> It is good that AM_PROG_VALAC does not abort when valac is not found,
> since most upstream tarballs contain generated C files as well.
> 
> However, if MINIMUM-VERSION is given and the version comparison fails,
> it aborts.  It would be nice if the behavior is controllable.
>
Agreed.  I plan to apply your patch (or a tweaked version thereof) before
Automke 1.13 is released.

> Here is a patch to add ACTION-IF-FOUND and ACTION-IF-NOT-FOUND to
> AM_PROG_VALAC.
>
I assume you've tried to make this compatible with the behaviour of
AM_PATH_PYTHON as much as possible, right?

Also, your patch lacks NEWS entries and documentation updates.  No
need to enhance and resend the patch though, as I can add them quite
easily myself (this is in fact more of a "note to self" rather than
an objection to you).

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]