Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works

[Eric Blake]

On 05/01/2012 10:04 AM, Stefano Lattarini wrote:
> After the last changes, configure will ensure that the shell
> selected to run the test scripts can correctly propagate exit
> status to the exit trap when 'set -e' is in effect.
> 
> * configure.ac (sh_errexit_works): Do not AC_SUBST it anymore.
> * defs-static.in (sh_errexit_works): Do not initialize
> from the AC_SUBST value anymore.
> * defs (trap): Trap the EXIT signal unconditionally.
> * t/self-check-explicit-skips.sh: Do not skip the test if
> '$sh_errexit_works' is != "yes", this check doesn't make
> sense anymore.
> * t/self-check-cleanup.tap: Likewise.
> * t/self-check-exit.tap: Assume the exit trap is always
> installed by ./defs.
> 
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
>  configure.ac                   |    3 ---
>  defs                           |    3 +--
>  defs-static.in                 |    3 ---
>  t/self-check-cleanup.tap       |    4 ----
>  t/self-check-exit.tap          |   13 +------------
>  t/self-check-explicit-skips.sh |    2 --
>  6 files changed, 2 insertions(+), 26 deletions(-)

Nice cleanups!

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature