automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Scripts in pkglibexecdir?


From: Stefano Lattarini
Subject: Re: Scripts in pkglibexecdir?
Date: Tue, 03 Jan 2012 22:22:53 +0100

On 01/03/2012 01:06 PM, Stefano Lattarini wrote:
> On 01/03/2012 12:09 PM, Peter Rosin wrote:
>> Stefano Lattarini skrev 2012-01-03 09:09:
>>> diff --git a/NEWS b/NEWS
>>> index fa1e75e..fbc2e59 100644
>>> --- a/NEWS
>>> +++ b/NEWS
>>> @@ -77,6 +77,11 @@ New in 1.11.0a:
>>>  
>>>  Bugs fixed in 1.11.0a:
>>>  
>>> +* Bugs introduced by 1.11.2:
>>> +
>>> +  - Automake does not erroneously flag the valid `pkglibexec_SCRIPTS'
>>> +    prefix/primary combination as invalid.
>>> +
>>
>> Error: too many negations
>>
>> I don't understand that sentence and can't be sure what was fixed
>> and what the bug was...
>>
> What about this then?
> 
>  - Automake correctly recognizes the prefix/primary combination
>    `pkglibexec_SCRIPTS' as valid.
>
I did one more little tweak, and went for this finally:

  - Automake now correctly recognizes the prefix/primary combination
   `pkglibexec_SCRIPTS' as valid.

More importantly, I've made the following adjustment to the test
`primary-prefix-invalid-couples.test', to avoid a spurious failure:

  --- a/tests/primary-prefix-invalid-couples.test
  +++ b/tests/primary-prefix-invalid-couples.test
  @@ -79,7 +79,7 @@ for primary in $primaries; do
         prefixes_ok='bin sbin libexec pkglibexec'
         ;;
       SCRIPTS)
  -      prefixes_ok='bin sbin libexec pkgdata'
  +      prefixes_ok='bin sbin libexec pkglibexec pkgdata'
         ;;
       DATA)
         prefixes_ok='data dataroot pkgdata doc html dvi pdf ps

I've then pushed the patch.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]