Re: [PATCH] {msvc} tests: few improvements to some `ar-lib' related tests

[Stefano Lattarini]

On Tuesday 25 October 2011, Peter Rosin wrote:
> Stefano Lattarini skrev 2011-10-25 13:44:
> > I'd like to push the attached patch to the `msvc' branch.
> > 
> > Peter, could you take a look at the patch, and preferably also
> > test it?  I want to have your ACK before proceeding.
> 
> I tested it and have some comments, inline in below snipped patch:
> 
> > diff --git a/ChangeLog b/ChangeLog
> ...
> > +2011-10-25  Peter Rosin  <address@hidden>
> 
> Not really true, at least I have no memories of this :-)
>
Eh eh :-)  Fixed.

> > diff --git a/tests/ar-lib5a.test b/tests/ar-lib5a.test
> ...
> > +cat - "$testsrcdir"/../lib > auxdir/ar-lib << 'END'
> 
> Needs to be
> cat - "$testsrcdir"/../lib/ar-lib > auxdir/ar-lib << 'END'
>
Oops, fixed.

> > +#! /bin/sh
> > +: > ar-lib-worked
> >  END
> >  chmod +x auxdir/ar-lib
> >  
> > diff --git a/tests/ar-lib5b.test b/tests/ar-lib5b.test
> > index 181c24b..52deab5 100755
> > --- a/tests/ar-lib5b.test
> > +++ b/tests/ar-lib5b.test
> > @@ -51,7 +51,7 @@ END
> >  
> >  mkdir auxdir
> >  cat > auxdir/ar-lib << 'END'
> > -# /bin/sh
> > +#! /bin/sh
> >  :> ar-lib-worked
> 
> Why didn't you add a space here? Keep the tests in sync, ya know... :-) :-)
>
Rather, I've removed the gratuitously-added extra space from
`ar-lib5a.test' -- this preserves the "synchronization" between
the two tests, and minimizes the git diffs :-)

> I have attached the verbose output of the two tests.  Looks ok to me.
> 
Thanks.  I've now pushed the patch.

Stefano