[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix aclocal-print-acdir.test
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests: fix aclocal-print-acdir.test |
Date: |
Thu, 20 Oct 2011 23:00:21 +0200 |
Stefano Lattarini wrote:
> On Thursday 20 October 2011, Jim Meyering wrote:
>> Without the patch below, I would consistently see this failure:
>>
>> FAIL: aclocal-print-acdir.test (exit: 1)
>> ========================================
>> + set -e
>> ...
>> ++ aclocal-1.11a -Werror --print-ac-dir
>> + test /h/j/w/co/automake/m4/acdir = /h/j/w/co/automake/m4
>> + exit_status=1
>> + set +e
>> ...
>>
>> I haven't delved into it to see how this test could be succeeding for
>> anyone else, so the patch may well be wrong.
>>
> No your fix is right. The failure is probably the result of a botched
> merge of long(ish) time ago; I've bever bothered to look into it better,
> since the test has been extended and improved in the `testusuite-work'
> branch (where it also works meaningfully under "make installcheck"),
> making the failure disappear there.
>
> Feel free to push the patch to master.
Done.
> Thanks, and sorry for the noise,
I saw 5 other "make check" failures on master this morning.
I suppose it's not worth investigating them, given how much
is happening in testsuite-work.
- [PATCH] tests: fix aclocal-print-acdir.test, Jim Meyering, 2011/10/20
- Re: [PATCH] tests: fix aclocal-print-acdir.test, Stefano Lattarini, 2011/10/20
- Re: [PATCH] tests: fix aclocal-print-acdir.test,
Jim Meyering <=
- testsuite on master (was: Re: [PATCH] tests: fix aclocal-print-acdir.test), Stefano Lattarini, 2011/10/20
- Re: testsuite on master, Jim Meyering, 2011/10/20
- [PATCH] {master} tests: fix spurious failures due to missing 'yywrap()' function (was: Re: testsuite on master), Stefano Lattarini, 2011/10/25
- Re: [PATCH] {master} tests: fix spurious failures due to missing 'yywrap()' function, Jim Meyering, 2011/10/25
- Re: [PATCH] {master} tests: fix spurious failures due to missing 'yywrap()' function, Stefano Lattarini, 2011/10/25