automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {maint} tests: avoid spurious failure of 'uninstall-fail.test' on


From: Stefano Lattarini
Subject: [FYI] {maint} tests: avoid spurious failure of 'uninstall-fail.test' on Cygwin
Date: Wed, 19 Oct 2011 13:44:37 +0200

* tests/uninstall-fail.test: Be sure to really skip this test
on systems that allows files to be removed from unwritable
directories.  Motivated by a spurious failure on Cygwin 1.5.
---
 ChangeLog                 |    7 +++++++
 tests/uninstall-fail.test |    8 +++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c3b041d..44240f9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-10-19  Stefano Lattarini  <address@hidden>
+
+       tests: avoid spurious failure of 'uninstall-fail.test' on Cygwin
+       * tests/uninstall-fail.test: Be sure to really skip this test
+       on systems that allows files to be removed from unwritable
+       directories.  Motivated by a spurious failure on Cygwin 1.5.
+
 2011-09-28  Stefano Lattarini  <address@hidden>
 
        maintcheck: fix usage of `cd' instead of `$(am__cd)'
diff --git a/tests/uninstall-fail.test b/tests/uninstall-fail.test
index a3e7a7a..a57b665 100755
--- a/tests/uninstall-fail.test
+++ b/tests/uninstall-fail.test
@@ -24,6 +24,11 @@
 
 set -e
 
+mkdir d
+: > d/f
+chmod a-w d || skip "cannot make directories unwritable"
+rm -f d/f && skip_ "can delete files from unwritable directories"
+
 cat >> configure.in << 'END'
 AC_OUTPUT
 END
@@ -46,9 +51,6 @@ mkdir $inst $inst/share
 : > $inst/share/foobar.txt
 
 chmod a-w $inst/share
-touch $inst/share/t && skip_ "cannot make directories unwritable"
-rm -f $inst/share/t
-
 $MAKE uninstall >output 2>&1 && { cat output; Exit 1; }
 cat output
 grep "rm: .*foobar\.txt" output
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]