Re: [FYI] {maint} parallel-tests: warn on conditional TEST_EXTENSIONS definition

[Stefano Lattarini]

On Friday 07 October 2011, Stefano Lattarini wrote:
> Before this change, automake would have still bailed out, but
> with a confusing error message (about an invalid redefinition
> of TEST_EXTENSIONS).
> 
> * automake.in (handle_tests): Warn explicitly if TEST_EXTENSIONS
> has conditional contents.
> * tests/test-extensions-con.test: New test.
> * tests/Makefile.am (TESTS): Add it.
> * NEWS: Update.
Sorry, I've sent an older version of the patch rather than the final
one.  Consider this squashed in:

diff --git a/NEWS b/NEWS
index 822498a..7e30ed0 100644
--- a/NEWS
+++ b/NEWS
@@ -53,7 +53,7 @@ Bugs fixed in 1.11.0a:
     rejects invalid entries and conditional contents in TEST_EXTENSIONS,
     instead of issuing confusing and apparently unrelated error messages
     (e.g., "non-POSIX variable name", "bad characters in variable name",
-    or "redefinition of TEST_EXTENSIONS, ), or even, in some situations,
+    or "redefinition of TEST_EXTENSIONS), or even, in some situations,
     silently producing broken `Makefile.in' files.
 
   - The `silent-rules' option now also silences all compile rules if dependency

diff --git a/automake.in b/automake.in
index d655b69..516e594 100755
--- a/automake.in
+++ b/automake.in
@@ -4987,8 +4987,8 @@ sub handle_tests
              define_variable ('TEST_EXTENSIONS', $suff, INTERNAL);
             }
           my $var = var 'TEST_EXTENSIONS';
-          # Currently, we are not able to deal with conditional
-          # definitions of TEST_EXTENSIONS.
+          # Currently, we are not able to deal with conditional contents
+          # in TEST_EXTENSIONS.
           if ($var->has_conditional_contents)
            {
             msg_var 'unsupported', $var,