Re: [FYI] testsuite: fix spurious failure in a test on TAP support

[Stefano Lattarini]

On Sunday 07 August 2011, Stefano Lattarini wrote:
> * tests/tap-passthrough-exit.test: When the `--ignore-exit' flag
> of the TAP driver is used, don't look for a message reporting the
> non-zero exit statuses of tests in the log files; such message is
> not expected to be there anymore.  Related simplifications.
> ---
>  ChangeLog                       |    8 ++++++++
>  tests/tap-passthrough-exit.test |   11 ++---------
>  2 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 33ac71c..328ca84 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,13 @@
>  2011-08-07  Stefano Lattarini  <address@hidden>
>  
> +     testsuite: fix spurious failure in a test on TAP support
> +     * tests/tap-passthrough-exit.test: When the `--ignore-exit' flag
> +     of the TAP driver is used, don't look for a message reporting the
> +     non-zero exit statuses of tests in the log files; such message is
> +     not expected to be there anymore.  Related simplifications.
> +
> +2011-08-07  Stefano Lattarini  <address@hidden>
> +
>       tap: plan location is more liberal w.r.t. non-TAP lines
>       With this change, only lines that are TAP results will matter
>       w.r.t. the position of the TAP plan in the input; for example,
> diff --git a/tests/tap-passthrough-exit.test b/tests/tap-passthrough-exit.test
> index ae8ffa8..68d7071 100755
> --- a/tests/tap-passthrough-exit.test
> +++ b/tests/tap-passthrough-exit.test
> @@ -53,14 +53,7 @@ for e in $exit_statuses; do
>    done
>  done
>  
> -st=0
> -env TEST_LOG_DRIVER_FLAGS='--ignore-exit' $MAKE -e check || st=$?
> -for e in $exit_statuses; do cat exit-$e.log; done
> -cat test-suite.log
> -test $st -eq 0 || Exit 1
> -
> -for e in $exit_statuses; do
> -  grep "exit-$e\\.test - exited with status $e$" exit-$e.log
> -done
> +env TEST_LOG_DRIVER_FLAGS='--ignore-exit' $MAKE -e check
> +$FGREP ".test - exited with status" *.log && Exit 1
>  
>  :
> 
Sorry I forgot to add: this has been applied to the 'test-protocols'
branch.

Sorry for the noise,
  Stefano