automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] check: don't use multi-line coloring for the report


From: Ralf Wildenhues
Subject: Re: [PATCH] check: don't use multi-line coloring for the report
Date: Mon, 20 Jun 2011 22:44:41 +0200

* Ralf Wildenhues wrote on Mon, Jun 20, 2011 at 10:29:02PM CEST:
> * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:33:53AM CEST:
> > +# Prefix each line by 'col' and terminate each with 'std', for coloring.
> > +# Multi line coloring is problematic with "less -R", so we really need
> > +# to color each line individually.
> 
> Inconsistent comment level, when compared with below.  I'd use '#' here,

D'oh.  I meant:  I'd use '##' here.  Sorry about that.
(Also, this is so minor it can be dealt with along other changes later.)

> as this is not really interesting to anyone reading Makefile.in files.
> I acknowledge that they are undercommented for many users, but then again,
> getting them up to a comment level easily understandable for everyone
> would just blow their size up a real lot, so a better recommendation is
> to look at the .am files.  And make sure they are commented well, but not
> too repetitious.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]