[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI] {testsuite-work} tests: prefer `skip_' over `echo ...; Exit 77'
From: |
Stefano Lattarini |
Subject: |
[FYI] {testsuite-work} tests: prefer `skip_' over `echo ...; Exit 77' |
Date: |
Wed, 1 Jun 2011 16:47:04 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
* tests/self-check-cleanup.test: When the test must be skipped,
use `skip_ REASON' instead of `echo REASON; Exit 77'. Also,
make the skip message shorter and clearer.
---
ChangeLog | 7 +++++++
tests/self-check-cleanup.test | 3 +--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7100f28..cc9dd2e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2011-06-01 Stefano Lattarini <address@hidden>
+ tests: prefer `skip_' over `echo ...; Exit 77'
+ * tests/self-check-cleanup.test: When the test must be skipped,
+ use `skip_ REASON' instead of `echo REASON; Exit 77'. Also,
+ make the skip message shorter and clearer.
+
+2011-06-01 Stefano Lattarini <address@hidden>
+
tests: fix spurious failures in self tests
Our ad-hoc usage of `tests/defs' in the testsuite's self tests
stopped working properly when we made the test scripts re-execute
diff --git a/tests/self-check-cleanup.test b/tests/self-check-cleanup.test
index f9a8658..7660316 100755
--- a/tests/self-check-cleanup.test
+++ b/tests/self-check-cleanup.test
@@ -20,8 +20,7 @@
. ./defs || Exit 1
if test x"$sh_errexit_works" != x"yes"; then
- echo "$me: the shell can't have a working exit trap with 'set -e'" >&2
- Exit 77
+ skip_ "$me: no working exit trap with 'set -e'"
fi
# We still need a little hack to make ./defs work outside automake's
--
1.7.2.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [FYI] {testsuite-work} tests: prefer `skip_' over `echo ...; Exit 77',
Stefano Lattarini <=