automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.


From: Ralf Wildenhues
Subject: Re: [PATCH] {maint} Improve and extend tests on de-ansification support.
Date: Sat, 20 Nov 2010 10:51:07 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET:
> On Monday 15 November 2010, Ralf Wildenhues wrote:
> > 
> > Well then we should adjust maintainer-check to not complain.  Either
> > way, maintainer-check results should not deteriorate.

> I'm not keen on meddling with the current maintainer-check rules, which
> are already quite hackish and not very easy to extend IMHO.

;-)

> So I'd like
> to seize this opportunity to push again my patch on a re-implementation
> of maintainer-check (in perl), which offers easy whitelisting of false
> positives, and more flexibility in pre-processing the input lines (which
> can be useful in case of more complex checks):
>  <http://lists.gnu.org/archive/html/automake-patches/2010-07/msg00084.html>

Gnulib has a few more facilities in this area, and several GNU projects
use them already.  It would be good if we worked toward common
facilities here, rather than diverging more from it.

Besides, I kinda dislike using perl where sed would suffice.  Yes, I'm
probably being selfish and stubborn on this one ...

Another nit at cited patch of yours is that makefile rules run in
parallel, the perl script tests don't.  This helps speed, but also
allows me to choose between stopping on first error or not (make -k).

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]